You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2012/04/28 00:30:50 UTC
[jira] [Updated] (SOLR-1893) common code in LRUCache and
FastLRUCache should be refactored into SolrCacheBase
[ https://issues.apache.org/jira/browse/SOLR-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1893:
---------------------------
Attachment: SOLR-1893.patch
Updated tomas's patch to trunk with some tweaks
Tomas: in general your patch looks good to me, but i did remove the "populateLst" method -- even if it had a better name, i think that method just makes the subclasses harder to read, w/ really removing any duplication (yes they add the same keys, but the values come from differnet places)
> common code in LRUCache and FastLRUCache should be refactored into SolrCacheBase
> --------------------------------------------------------------------------------
>
> Key: SOLR-1893
> URL: https://issues.apache.org/jira/browse/SOLR-1893
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Attachments: SOLR-1893.patch, SOLR-1893.patch
>
>
> In SOLR-571 I created SolrCacheBase as a place to put some new code that i wanted to use in both LRUCache and FastLRUCache, but looking at those classes there is already quite a bit of cut/paste, and it would be nice to refactor anything that is duplicated up into the new parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org