You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/09/04 09:02:49 UTC
[PR] [SPARK-49509][CORE] Use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect` [spark]
cxzl25 opened a new pull request, #47987:
URL: https://github.com/apache/spark/pull/47987
### What changes were proposed in this pull request?
This PR aims to use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect`.
### Why are the changes needed?
https://github.com/apache/spark/pull/47733#pullrequestreview-2251276385
Allocating off-heap memory should use the `allocateDirectBuffer` API provided `by Platform`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
GA
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49509][CORE] Use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #47987: [SPARK-49509][CORE] Use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect`
URL: https://github.com/apache/spark/pull/47987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49509][CORE] Use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #47987:
URL: https://github.com/apache/spark/pull/47987#issuecomment-2329287353
Merged to master/3.5 for Apache Spark 3.5.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org