[jira] [Commented] (THRIFT-2851) Remove strange public Peek() from Go transports

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225289#comment-14225289 ] 

Hudson commented on THRIFT-2851:
--------------------------------

SUCCESS: Integrated in Thrift #1372 (See [https://builds.apache.org/job/Thrift/1372/])
THRIFT-2851 Remove strange public Peek() from Go transports (jensg: rev 1e7971cfff020be14bd30114f0dfe264797f259a)
* lib/go/thrift/memory_buffer.go
* lib/go/thrift/iostream_transport.go
* lib/go/thrift/socket.go
* lib/go/thrift/ssl_socket.go
* lib/go/thrift/http_client.go


> Remove strange public Peek() from Go transports
> -----------------------------------------------
>
>                 Key: THRIFT-2851
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2851
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>    Affects Versions: 0.9.2
>            Reporter: Chi Vinh Le
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> I've been seeing this public Peek() function in the GO library for a while, but
> still cannot figure out any sense to it.
> If there are useless, we can remove them right?
> This PR removes the public Peek() from the implemented transports.
> All tests still pass.
> PR: https://github.com/apache/thrift/pull/283



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)