You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "xbthink (via GitHub)" <gi...@apache.org> on 2023/08/11 09:51:33 UTC
[GitHub] [incubator-streampark] xbthink opened a new pull request, #2937: support flink native type savepoint
xbthink opened a new pull request, #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #2936 <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] xbthink commented on a diff in pull request #2937: support flink native type savepoint
Posted by "xbthink (via GitHub)" <gi...@apache.org>.
xbthink commented on code in PR #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937#discussion_r1293105106
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -1319,16 +1320,19 @@ public void cancel(Application appParam) throws Exception {
savePoint.setCreateTime(new Date());
savePoint.setTriggerTime(triggerTime);
savePointService.save(savePoint);
+ log.info("savePoint path: {} is saved", savePointDir);
}
if (isKubernetesApp(application)) {
k8SFlinkTrackMonitor.unWatching(toTrackId(application));
+ log.info("k8SFlinkTrackMonitor.unWatching");
Review Comment:
It is debug log, I have removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] xbthink commented on pull request #2937: support flink native type savepoint
Posted by "xbthink (via GitHub)" <gi...@apache.org>.
xbthink commented on PR #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937#issuecomment-1676869541
Thanks for your reviewing. I have modified codes, you can review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on a diff in pull request #2937: support flink native type savepoint
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on code in PR #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937#discussion_r1292936144
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -1319,16 +1320,19 @@ public void cancel(Application appParam) throws Exception {
savePoint.setCreateTime(new Date());
savePoint.setTriggerTime(triggerTime);
savePointService.save(savePoint);
+ log.info("savePoint path: {} is saved", savePointDir);
}
if (isKubernetesApp(application)) {
k8SFlinkTrackMonitor.unWatching(toTrackId(application));
+ log.info("k8SFlinkTrackMonitor.unWatching");
Review Comment:
we can make the log more readable.
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -1319,16 +1320,19 @@ public void cancel(Application appParam) throws Exception {
savePoint.setCreateTime(new Date());
savePoint.setTriggerTime(triggerTime);
savePointService.save(savePoint);
+ log.info("savePoint path: {} is saved", savePointDir);
}
if (isKubernetesApp(application)) {
k8SFlinkTrackMonitor.unWatching(toTrackId(application));
+ log.info("k8SFlinkTrackMonitor.unWatching");
}
},
e -> {
if (e.getCause() instanceof CancellationException) {
updateToStopped(application);
+ log.info("updateToStopped");
Review Comment:
same as above.
##########
streampark-console/streampark-console-webapp/src/views/flink/app/components/AppView/StopApplicationModal.vue:
##########
@@ -79,6 +79,17 @@
defaultValue: false,
afterItem: () => h('span', { class: 'conf-switch' }, 'Send max watermark before stopped'),
},
+ {
+ field: 'nativeFormat',
+ label: 'NativeFormat',
+ component: 'Switch',
+ componentProps: {
+ checkedChildren: 'ON',
+ unCheckedChildren: 'OFF',
+ },
+ defaultValue: false,
+ afterItem: () => h('span', { class: 'conf-switch' }, 'Use savepoint native format'),
+ },
Review Comment:
It's better hide this component when canceling without savepoint, besides, we may provide more info for users, like native format is supported since flink 1.15.
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -1319,16 +1320,19 @@ public void cancel(Application appParam) throws Exception {
savePoint.setCreateTime(new Date());
savePoint.setTriggerTime(triggerTime);
savePointService.save(savePoint);
+ log.info("savePoint path: {} is saved", savePointDir);
}
if (isKubernetesApp(application)) {
k8SFlinkTrackMonitor.unWatching(toTrackId(application));
+ log.info("k8SFlinkTrackMonitor.unWatching");
}
},
e -> {
if (e.getCause() instanceof CancellationException) {
updateToStopped(application);
+ log.info("updateToStopped");
} else {
- log.error("stop flink job fail.", e);
+ log.info("stop flink job fail.", e);
Review Comment:
maybe 'log.warn' is better here.
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/AccessTokenController.java:
##########
@@ -186,6 +186,7 @@ public RestResponse copyRestApiCurl(
.addFormData("id", appId)
.addFormData("savePointed", "false")
.addFormData("drain", "false")
+ .addFormData("type", "canonical")
Review Comment:
`flink/app/cancel` does not take a parameter named `type`, maybe you mean `.addFormData("nativeFormat", "false")` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] xbthink commented on pull request #2937: support flink native type savepoint
Posted by "xbthink (via GitHub)" <gi...@apache.org>.
xbthink commented on PR #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937#issuecomment-1674593483
I have used this pr at internal environment, and I am not familiar with the FE code.
Please review code, and give some suggestions. Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii merged pull request #2937: [ISSUE-2936][Feature] Support flink native type savepoint
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii merged PR #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] xbthink commented on a diff in pull request #2937: support flink native type savepoint
Posted by "xbthink (via GitHub)" <gi...@apache.org>.
xbthink commented on code in PR #2937:
URL: https://github.com/apache/incubator-streampark/pull/2937#discussion_r1293105328
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/AccessTokenController.java:
##########
@@ -186,6 +186,7 @@ public RestResponse copyRestApiCurl(
.addFormData("id", appId)
.addFormData("savePointed", "false")
.addFormData("drain", "false")
+ .addFormData("type", "canonical")
Review Comment:
yes, I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org