You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dilipbiswal <gi...@git.apache.org> on 2018/01/30 19:51:10 UTC

[GitHub] spark pull request #20441: [SPARK-23275] hive/tests have been failing when r...

GitHub user dilipbiswal opened a pull request:

    https://github.com/apache/spark/pull/20441

    [SPARK-23275] hive/tests have been failing when run locally on the laptop (Mac) with OOM

    ## What changes were proposed in this pull request?
    hive tests have been failing when they are run locally (Mac Os) after a recent change in the trunk. After running the tests for some time, the test fails with OOM with Error: unable to create new native thread.
    
    I noticed the thread count goes all the way up to 2000+ after which we start getting these OOM errors. Most of the threads seem to be related to the connection pool in hive metastore (BoneCP-xxxxx-xxxx ). This behaviour change is happening after we made the following change to HiveClientImpl.reset()
    
    ``` SQL
     def reset(): Unit = withHiveState {
        try {
          // code
        } finally {
          runSqlHive("USE default")  ===> this is causing the issue
        }
    ```
    I am proposing to temporarily back-out part of a fix made to address SPARK-23000 to resolve this issue while we work-out the exact reason for this sudden increase in thread counts.
    
    ## How was this patch tested?
    Ran hive/test multiple times in different machines.
    
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dilipbiswal/spark hive_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20441
    
----
commit 983aa1839e6991b72f02639e0bd5355200da1d47
Author: Dilip Biswal <db...@...>
Date:   2018-01-30T19:37:25Z

    [SPARK-23275] hive/tests have been failing when run locally on the laptop (Mac) with OOM

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20441: [SPARK-23275][SQL] hive/tests have been failing w...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20441


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by liufengdb <gi...@git.apache.org>.
Github user liufengdb commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    @gatorsmile sorry for the late reply. I think the root cause is in hive metastore. I created one pr to bypass it: https://github.com/apache/spark/pull/20562


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275] hive/tests have been failing when run loca...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86844/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275] hive/tests have been failing when run loca...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    **[Test build #86844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86844/testReport)** for PR 20441 at commit [`983aa18`](https://github.com/apache/spark/commit/983aa1839e6991b72f02639e0bd5355200da1d47).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    @srowen Hello, yeah, i saw the same error. Quite a few errors like 
    ``` 
    java.lang.RuntimeException: Unable to instantiate org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient
    ```
    with underlying reason
    ```
    Caused by: java.lang.OutOfMemoryError: unable to create new native thread
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275] hive/tests have been failing when run loca...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/401/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    Many thanks @gatorsmile .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    @liufengdb You might be interested in this 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    For the record, what was the error? I got this running on OS X from master with `-Phive` before this change, but was that same problem?
    
    ```
    HiveWindowFunctionQuerySuite:
    *** RUN ABORTED ***
      org.apache.spark.sql.AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to fetch table part. Unable to instantiate org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient;
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    Thanks! Merged to master/2.3


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20441: [SPARK-23275][SQL] hive/tests have been failing when run...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20441
  
    **[Test build #86844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86844/testReport)** for PR 20441 at commit [`983aa18`](https://github.com/apache/spark/commit/983aa1839e6991b72f02639e0bd5355200da1d47).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org