You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/10/11 17:09:41 UTC
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8259
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
A recent commit "IMPALA-5448: fix invalid number of splits reported in
Parquet scan node" neglected to account for the fact that in some
environments, Impala runs without Hive. The typical pattern for tests
that use Hive is skip them if they are executed against such
environments.
Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
---
M tests/query_test/test_scanners.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/8259/1
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 18:03:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
A recent commit "IMPALA-5448: fix invalid number of splits reported in
Parquet scan node" neglected to account for the fact that in some
environments, Impala runs without Hive. The typical pattern for tests
that use Hive is skip them if they are executed against such
environments.
Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Reviewed-on: http://gerrit.cloudera.org:8080/8259
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/query_test/test_scanners.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1328/
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 22:15:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
Patch Set 2: Code-Review+2
Hit IMPALA-6027; rebased to include its fix and carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 22:26:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 02:16:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1328/
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 18:16:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6040: skip test multi compression types where Hive isn't supported
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8259 )
Change subject: IMPALA-6040: skip test_multi_compression_types where Hive isn't supported
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1333/
--
To view, visit http://gerrit.cloudera.org:8080/8259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4b72839f8ac3bcb824287d02dd6964eea3e3e
Gerrit-Change-Number: 8259
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 22:27:25 +0000
Gerrit-HasComments: No