You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by GitBox <gi...@apache.org> on 2019/02/25 17:23:46 UTC

[GitHub] clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List

clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259932073
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
 ##########
 @@ -190,9 +190,7 @@ private void decrementRefCount(MessageReference refmsg) {
 
    @Override
    public synchronized List<MessageReference> getRelatedMessageReferences() {
-      List<MessageReference> listRet = new LinkedList<>();
 
 Review comment:
   this is dangerous... The RefsOperation will clear the list upon completion.
   The callers could be using the list for other factors...
   
   You really need the isolation here.
   
   
   Can you close this PR? This is meant to be.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services