[jira] [Commented] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

["Nicolas Malin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816055#comment-16816055 ] 

Nicolas Malin commented on OFBIZ-9551:
--------------------------------------

Hello,

I suggest to finish this task to return at the simple expression of CRUD and remove the control on userLogin.partyId == parameters.partyId

If we really want to keep it, it's useful to create a dedicate service for that like "addMeToCampaignMarketing"

[^OFBIZ-9551-simple.patch]

> Convert createMarketingCampaignRole service to entity-auto service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-9551
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9551
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Deepak Dixit
>            Priority: Major
>         Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at CampaignServices.xml which is of no use and can be deleted, we can move that code to a separate permission check service that can be used elsewhere as well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)