You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/15 08:19:35 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request #19674: Fix CD pipeline - python formatting issue
bgawrych opened a new pull request #19674:
URL: https://github.com/apache/incubator-mxnet/pull/19674
## Description ##
Quantization commit broke [CD pipeline to release python docker images](https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/2186/pipeline)
We've used f-strings in quantization.py file and it fails because CD pipeline uses python 3.5 and this feature is available since version 3.6 of python.
@mseth10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19674: Fix CD pipeline - python formatting issue
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19674:
URL: https://github.com/apache/incubator-mxnet/pull/19674#issuecomment-745382727
How about fixing the CD pipeline to use Python 3.6? As Python 3.5 is untested, it's very risky to use it on CD @mseth10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19674: Fix CD pipeline - python formatting issue
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19674:
URL: https://github.com/apache/incubator-mxnet/pull/19674#issuecomment-745130319
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, windows-gpu, clang, centos-cpu, edge, miscellaneous, unix-gpu, centos-gpu, website, windows-cpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #19674: Fix CD pipeline - python formatting issue
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #19674:
URL: https://github.com/apache/incubator-mxnet/pull/19674#issuecomment-749835360
> How about fixing the CD pipeline to use Python 3.6? As Python 3.5 is untested, it's very risky to use it on CD @mseth10
Sure. Currently we are using ubuntu16 [base images](https://github.com/apache/incubator-mxnet/blob/master/cd/utils/mxnet_base_image.sh) that come with Python3.5. Do you know if we can upgrade them to ubuntu18? @leezu
Or we can upgrade python version on ubuntu16 docker images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych closed pull request #19674: Fix CD pipeline - python formatting issue
Posted by GitBox <gi...@apache.org>.
bgawrych closed pull request #19674:
URL: https://github.com/apache/incubator-mxnet/pull/19674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #19674: Fix CD pipeline - python formatting issue
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #19674:
URL: https://github.com/apache/incubator-mxnet/pull/19674#issuecomment-749873849
> > How about fixing the CD pipeline to use Python 3.6? As Python 3.5 is untested, it's very risky to use it on CD @mseth10
>
> Sure. Currently we are using ubuntu16 [base images](https://github.com/apache/incubator-mxnet/blob/master/cd/utils/mxnet_base_image.sh) that come with Python3.5. Do you know if we can upgrade them to ubuntu18? @leezu
> Or we can upgrade python version on ubuntu16 docker images.
As per offline discussion with @josephevans , we need to continue using ubuntu16 due to compatibility concerns. Will create a PR to upgrade Python version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org