[GitHub] JaroslavTulach commented on a change in pull request #564: Allow modules to be located in cluster.dir/cnb structure

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #564: Allow modules to be located in cluster.dir/cnb structure
URL: https://github.com/apache/incubator-netbeans/pull/564#discussion_r191181807
 
 

 ##########
 File path: nbbuild/antsrc/org/netbeans/nbbuild/GetModuleName.java
 ##########
 @@ -70,7 +78,12 @@ public void execute() throws BuildException {
             if (dir == null) {
                 throw new BuildException("This module (" + this.getProject().getBaseDir() + ") is on different path than the root dir", this.getLocation());
             }
-            this.getProject().setProperty(name, modulename.toString()); // XXX should be setNewProperty, when that is possible
+            final String mName = modulename.toString();
+            this.getProject().setNewProperty(name, mName);
 
 Review comment:
   After executing this task the name property refers to path to the module (with cluster as directory), and `id` property refers to the short name as used in `cluster.properties` and co.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists