You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/03/10 01:55:45 UTC

Review Request 57489: RANGER-1435: Allow different files to be specified for unix based usersync - for ranger-0.6 branch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57489/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1435
    https://issues.apache.org/jira/browse/RANGER-1435


Repository: ranger


Description
-------

Made similar changes as in Review request 57488 for raner-0.6 branch


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java eac0073 
  ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java c71bc90 
  ugsync/src/test/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilderTest.java e4d5456 
  ugsync/src/test/resources/groupFile PRE-CREATION 
  ugsync/src/test/resources/passwordFile PRE-CREATION 


Diff: https://reviews.apache.org/r/57489/diff/1/


Testing
-------

Successfully ran unit tests.


Thanks,

Sailaja Polavarapu


Re: Review Request 57489: RANGER-1435: Allow different files to be specified for unix based usersync - for ranger-0.6 branch

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57489/#review168677
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On March 10, 2017, 9:15 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57489/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 9:15 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1435
>     https://issues.apache.org/jira/browse/RANGER-1435
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Made similar changes as in Review request 57488 for raner-0.6 branch
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java eac0073 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java c71bc90 
>   ugsync/src/test/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilderTest.java e4d5456 
>   ugsync/src/test/resources/groupFile.txt PRE-CREATION 
>   ugsync/src/test/resources/passwordFile.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57489/diff/3/
> 
> 
> Testing
> -------
> 
> Successfully ran unit tests.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Re: Review Request 57489: RANGER-1435: Allow different files to be specified for unix based usersync - for ranger-0.6 branch

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57489/
-----------------------------------------------------------

(Updated March 10, 2017, 9:15 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

After fixing some minor issue of using the new filenames in the test code, regenrated the full patch for ranger-0.6 branch


Bugs: RANGER-1435
    https://issues.apache.org/jira/browse/RANGER-1435


Repository: ranger


Description
-------

Made similar changes as in Review request 57488 for raner-0.6 branch


Diffs (updated)
-----

  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java eac0073 
  ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java c71bc90 
  ugsync/src/test/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilderTest.java e4d5456 
  ugsync/src/test/resources/groupFile.txt PRE-CREATION 
  ugsync/src/test/resources/passwordFile.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/57489/diff/3/

Changes: https://reviews.apache.org/r/57489/diff/2-3/


Testing
-------

Successfully ran unit tests.


Thanks,

Sailaja Polavarapu


Re: Review Request 57489: RANGER-1435: Allow different files to be specified for unix based usersync - for ranger-0.6 branch

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57489/
-----------------------------------------------------------

(Updated March 10, 2017, 6:50 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

renamed the test resources file (passwordFile and groupFile) with .txt extension in order to exclude from rat plugin check


Bugs: RANGER-1435
    https://issues.apache.org/jira/browse/RANGER-1435


Repository: ranger


Description
-------

Made similar changes as in Review request 57488 for raner-0.6 branch


Diffs (updated)
-----

  ugsync/src/test/resources/groupFile 89f7564 
  ugsync/src/test/resources/groupFile.txt PRE-CREATION 
  ugsync/src/test/resources/passwordFile 0e8e10b 
  ugsync/src/test/resources/passwordFile.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/57489/diff/2/

Changes: https://reviews.apache.org/r/57489/diff/1-2/


Testing
-------

Successfully ran unit tests.


Thanks,

Sailaja Polavarapu