You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hawq.apache.org by kavinderd <gi...@git.apache.org> on 2016/09/07 22:10:32 UTC

[GitHub] incubator-hawq pull request #821: HAWQ-931. ORC optimized profile for PPD/CP

Github user kavinderd commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/821#discussion_r77913853
  
    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveColumnarSerdeResolver.java ---
    @@ -76,6 +77,8 @@ void parseUserData(InputData input) throws Exception {
                 serdeType = HiveInputFormatFragmenter.PXF_HIVE_SERDES.COLUMNAR_SERDE;
             } else if (serdeEnumStr.equals(HiveInputFormatFragmenter.PXF_HIVE_SERDES.LAZY_BINARY_COLUMNAR_SERDE.name())) {
                 serdeType = HiveInputFormatFragmenter.PXF_HIVE_SERDES.LAZY_BINARY_COLUMNAR_SERDE;
    +        } else if (serdeEnumStr.equals(HiveInputFormatFragmenter.PXF_HIVE_SERDES.VECTORIZED_ORC_SERDE.name())) {
    +            serdeType = HiveInputFormatFragmenter.PXF_HIVE_SERDES.VECTORIZED_ORC_SERDE;
    --- End diff --
    
    Since there is a ORCSerdeResolver now, why do we need this block? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---