You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/01 03:31:00 UTC
[jira] [Work logged] (HADOOP-17276) Extend CallerContext to make it
include many items
[ https://issues.apache.org/jira/browse/HADOOP-17276?focusedWorklogId=493263&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493263 ]
ASF GitHub Bot logged work on HADOOP-17276:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/20 03:30
Start Date: 01/Oct/20 03:30
Worklog Time Spent: 10m
Work Description: ferhui commented on a change in pull request #2327:
URL: https://github.com/apache/hadoop/pull/2327#discussion_r497964091
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
##########
@@ -109,11 +113,47 @@ public String toString() {
/** The caller context builder. */
public static final class Builder {
- private final String context;
+ private static final String KEY_VALUE_SEPARATOR = ":";
+ private final String fieldSeparator;
+ private final StringBuilder sb = new StringBuilder();
private byte[] signature;
public Builder(String context) {
- this.context = context;
+ this(context, new Configuration());
+ }
+
+ public Builder(String context, Configuration conf) {
+ if (isValid(context)) {
+ sb.append(context);
+ }
+ fieldSeparator = conf.get(HADOOP_CALLER_CONTEXT_SEPARATOR_KEY,
+ HADOOP_CALLER_CONTEXT_SEPARATOR_DEFAULT);
+ checkFieldSeparator(fieldSeparator);
+ }
+
+ /**
+ * Check whether the separator is legal.
+ * The illegal separators include '\t', '\n', '=', etc.
+ * Throw IllegalArgumentException if the separator is Illegal.
+ * @param separator the separator of fields.
+ */
+ private void checkFieldSeparator(String separator) {
+ if (separator.contains("\t") || separator.contains("\n")
Review comment:
It's ok. refactor checking separator, and add UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 493263)
Time Spent: 7h 10m (was: 7h)
> Extend CallerContext to make it include many items
> --------------------------------------------------
>
> Key: HADOOP-17276
> URL: https://issues.apache.org/jira/browse/HADOOP-17276
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Hui Fei
> Assignee: Hui Fei
> Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Now context is string. We need to extend the CallerContext because context may contains many items.
> Items include
> * router ip
> * MR or CLI
> * etc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org