You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/05/30 14:21:12 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #14982: [Bugfix][TIR][VTA] Update host-side target, even without device func

Lunderberg opened a new pull request, #14982:
URL: https://github.com/apache/tvm/pull/14982

   This resolves an issue introduced by the combination of https://github.com/apache/tvm/pull/14918 and
   https://github.com/apache/tvm/pull/14945.  The bug occurred for targets that do not require device-side codegen, but do require a `device_type` other than `kDLCPU`.  It wasn't caught by CI, as the issue only occurred with the combination of both PRs.
   
   1. #14918 updated `SplitHostDevice` to only modify the `"target"` attribute when a device-side function has been extracted.
   
   2. For VTA, there is no device-side function, as everything is done through host-side API calls.
   
   3. From (1) and (2), the VTA examples kept the target `T.target("ext_dev", host="llvm")` after the `SplitHostDevice` pass, instead of being updated to `T.target("llvm")`.
   
   4. #14945 restricted CombineContextCall to only apply to host-side passes.
   
   5. From (4) and (5), the `CombineContextCall` pass was no longer applied to the VTA context calls.
   
   This PR fixes `SplitHostDevice`, updating the target from `T.target("ext_dev", host="llvm")` to `T.target("llvm")`, even if no device sections have been extracted from the function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Lunderberg merged pull request #14982: [Bugfix][TIR][VTA] Update host-side target, even without device func

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg merged PR #14982:
URL: https://github.com/apache/tvm/pull/14982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #14982: [Bugfix][TIR][VTA] Update host-side target, even without device func

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14982:
URL: https://github.com/apache/tvm/pull/14982#issuecomment-1568524652

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #14982: [Bugfix][TIR][VTA] Update host-side target, even without device func

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14982:
URL: https://github.com/apache/tvm/pull/14982#issuecomment-1568524668

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org