You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/30 03:41:51 UTC
[GitHub] [incubator-doris] xinyiZzz opened a new pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
xinyiZzz opened a new pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735
## Proposed changes
Currently, partition column can be defined as "allow null" when create table.
But errors may occur when null as the value of partition columns.
Therefore, modified to prohibit partition column to be defined to "allow null"
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
- [x] Compiling and unit tests pass locally with my changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735#issuecomment-709686702
@xinyiZzz , hi , i think we can discuss it in dev@ mail list.
Could you please send a email to start with it？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735#issuecomment-709373847
> Hi, @xinyiZzz
> Is there an issue describing the specific problem?
> The previous version of Doris had problems when handling Null partition columns, and the current code should have been fixed.
> If you want to prohibit the Partition column from being null, you need to discuss it in the Issue or Mail list.
The null value to be a partition value is very confusing.
Currently, the null value is stored in the partition with MIN_VALUE lower bound. But if that partition is dropped, the null value
can not be loaded. So it is not a good way to solve the problem.
Some other database use a special partition to save null value. But I think it is very hard to maintain and hard to understand.
Is it necessary to allow null value to be a partition value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735#issuecomment-709685512
> > Hi, @xinyiZzz
> > Is there an issue describing the specific problem?
> > The previous version of Doris had problems when handling Null partition columns, and the current code should have been fixed.
> > If you want to prohibit the Partition column from being null, you need to discuss it in the Issue or Mail list.
>
> The null value to be a partition value is very confusing.
> Currently, the null value is stored in the partition with MIN_VALUE lower bound. But if that partition is dropped, the null value
> can not be loaded. So it is not a good way to solve the problem.
>
> Some other database use a special partition to save null value. But I think it is very hard to maintain and hard to understand.
> Is it necessary to allow null value to be a partition value?
Yes，I agree with you about Null partition is confusing.
However some tables currently contain Null values. If the null partition column is not supported in the future, how to deal with the current existing data, I think there should be a more complete plan.
How about creating another issue to discuss about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735#issuecomment-718479166
> @xinyiZzz , hi , i think we can discuss it in dev@ mail list.
> Could you please send a email to start with it？
Sorry for the late reply. I have sent an email to Mail list to discuss this, thanks @imay @morningman for your reply and attention
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz closed pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
xinyiZzz closed pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz closed pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
xinyiZzz closed pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #4735: [Repair] modified to prohibit partition column to be defined to "allow null" when create table
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #4735:
URL: https://github.com/apache/incubator-doris/pull/4735#issuecomment-708097530
Hi, @xinyiZzz
Is there an issue describing the specific problem?
The previous version of Doris had problems when handling Null partition columns, and the current code should have been fixed.
If you want to prohibit the Partition column from being null, you need to discuss it in the Issue or Mail list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org