You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/07/16 09:56:45 UTC
[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request
#612: MINIFICPP-854: Capture RTSP Frame
arpadboda commented on a change in pull request #612: MINIFICPP-854: Capture RTSP Frame
URL: https://github.com/apache/nifi-minifi-cpp/pull/612#discussion_r303821228
##########
File path: libminifi/test/opencv-tests/CMakeLists.txt
##########
@@ -24,14 +24,14 @@ SET(OPENCV_TEST_COUNT 0)
FOREACH(testfile ${OPENCV_TESTS})
get_filename_component(testfilename "${testfile}" NAME_WE)
add_executable("${testfilename}" "${testfile}")
- createTests("${testfilename}")
target_include_directories(${testfilename} PRIVATE BEFORE "${CMAKE_SOURCE_DIR}/extensions/opencv/")
-
+ target_include_directories(${testfilename} PRIVATE BEFORE "${CMAKE_SOURCE_DIR}/extensions/standard-processors")
if (APPLE)
- target_link_libraries (${testfilename} -Wl,-all_load minifi-opencv)
+ target_link_libraries (${testfilename} -Wl,-all_load minifi-opencv minifi-standard-processors)
else ()
- target_link_libraries (${testfilename} -Wl,--whole-archive minifi-opencv -Wl,--no-whole-archive)
Review comment:
Could you to this the "standard" way we do this? (Just setting variables in conditions to match platform and have only one linker command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services