[GitHub] [pulsar] lhotari commented on a change in pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#discussion_r530813102



##########
File path: pom.xml
##########
@@ -200,7 +200,7 @@ flexible messaging model and an intuitive client API.</description>
     <protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
     <exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
     <aspectj-maven-plugin.version>1.11.1</aspectj-maven-plugin.version>
-    <license-maven-plugin.version>3.0</license-maven-plugin.version>
+    <license-maven-plugin.version>4.0.rc2</license-maven-plugin.version>

Review comment:
       3.0 was released in August 2016, so that's one of the reasons to get on 4.0.rc2 which was release in August 2020. I wouldn't be concerned that it's a rc version. The commit history of license-maven-plugin can be viewed at https://github.com/mycila/license-maven-plugin . It seems that there are quite a few fixes included in 4.0.rc2 compared to 3.0




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org