Re: svn commit: r1907965 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/ tests/cmdline/

[Jun Omae <ju...@gmail.com>]

Hi,

On 2023/03/02 20:10, kotkov@apache.org wrote:
> Author: kotkov
> Date: Thu Mar  2 11:10:34 2023
> New Revision: 1907965
> 
> URL: http://svn.apache.org/viewvc?rev=1907965&view=rev
> Log:
> Fix an issue where calling `svn upgrade` without arguments for a 1.15-format
> working copy resulted in an error:
> ...> Modified:
>     subversion/trunk/subversion/include/private/svn_wc_private.h
>     subversion/trunk/subversion/include/svn_client.h
>     subversion/trunk/subversion/libsvn_client/deprecated.c
>     subversion/trunk/subversion/libsvn_client/upgrade.c
>     subversion/trunk/subversion/libsvn_wc/deprecated.c
>     subversion/trunk/subversion/libsvn_wc/upgrade.c
>     subversion/trunk/subversion/svn/upgrade-cmd.c
>     subversion/trunk/subversion/tests/cmdline/externals_tests.py
>     subversion/trunk/subversion/tests/cmdline/upgrade_tests.py

After r1907965, build on Windows is failing with the following errors.

[[[
svn_client-1.lib(upgrade.obj) : error LNK2001: unresolved external symbol svn_wc__version_string_from_format [D:\a\subversion\subversion\build\win32\vcnet-vcproj\libsvn_client_dll.vcxproj]
D:\a\subversion\subversion\Release\subversion\libsvn_client\libsvn_client-1.dll : fatal error LNK1120: 1 unresolved externals [D:\a\subversion\subversion\build\win32\vcnet-vcproj\libsvn_client_dll.vcxproj]
]]]

I think we should move `svn_wc__version_string_from_format` declaration from
libsvn_wc/wc.h to include/private/svn_wc_private.h in order to export the
symbol.


-- 
Jun Omae <ju...@gmail.com> (大前 潤)

Re: svn commit: r1907965 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/ tests/cmdline/

[Evgeny Kotkov via dev <de...@subversion.apache.org>]

Jun Omae <ju...@gmail.com> writes:

> After r1907965, build on Windows is failing with the following errors.
>
> [[[
> svn_client-1.lib(upgrade.obj) : error LNK2001: unresolved external symbol svn_wc__version_string_from_format [D:\a\subversion\subversion\build\win32\vcnet-vcproj\libsvn_client_dll.vcxproj]
> D:\a\subversion\subversion\Release\subversion\libsvn_client\libsvn_client-1.dll : fatal error LNK1120: 1 unresolved externals [D:\a\subversion\subversion\build\win32\vcnet-vcproj\libsvn_client_dll.vcxproj]
> ]]]

Thanks, should be fixed in r1908042.


Regards,
Evgeny Kotkov