You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/11/30 00:58:14 UTC

[GitHub] incubator-beam pull request #1460: Revert "Remove WindowedValue.valueInEmpty...

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1460

    Revert "Remove WindowedValue.valueInEmptyWindows"

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This reverts commit 0e49b150e83d85ae432c640da937a9497068e71b, which breaks some DataflowRunner integration tests in ways that may take a minute to fix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam rollback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1460
    
----
commit 54435de54eb7d4bff8db2ae944bea1f8e813ecbd
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-11-30T00:57:09Z

    Revert "Remove WindowedValue.valueInEmptyWindows"
    
    This reverts commit 0e49b150e83d85ae432c640da937a9497068e71b, which breaks
    some DataflowRunner integration tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1460: Revert "Remove WindowedValue.valueInEmpty...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1460


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---