You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 16:23:32 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9025: ARROW-10259: [Rust] Add custom metadata to Field

alamb commented on a change in pull request #9025:
URL: https://github.com/apache/arrow/pull/9025#discussion_r553434218



##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -1500,6 +1590,7 @@ impl Field {
     }
 
     /// Merge field into self if it is compatible. Struct will be merged recursively.
+    /// NOTE: `self` may be updated to unexpected state in case of merge failure.

Review comment:
       I think this "good now, better later" strategy is a good one. I agree with @nevi-me 's suggestion




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org