You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2024/02/18 03:50:49 UTC
(doris) 15/15: [Bug] (plsql) procedure call to a non existing procedure, returning success (#31019)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 33aaacf2fa5366381e0d7382762b9273486d5431
Author: Vallish Pai <va...@gmail.com>
AuthorDate: Sun Feb 18 09:09:25 2024 +0530
[Bug] (plsql) procedure call to a non existing procedure, returning success (#31019)
Issue Number: close. #31018
state was set OK even in failure case. changed it.
---
.../main/java/org/apache/doris/plsql/executor/PlSqlOperation.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java b/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java
index 525ca612cd3..b98507c1a41 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/plsql/executor/PlSqlOperation.java
@@ -49,10 +49,11 @@ public class PlSqlOperation {
result.reset();
try {
Arguments args = new Arguments();
- args.parse(new String[] {"-e", statement});
+ args.parse(new String[] { "-e", statement });
exec.parseAndEval(args);
// Exception is not thrown after catch.
- // For example, select a not exist table will return empty results, exception will put into signals.
+ // For example, select a not exist table will return empty results, exception
+ // will put into signals.
exec.printExceptions();
String error = result.getError();
String msg = result.getMsg();
@@ -62,7 +63,6 @@ public class PlSqlOperation {
ctx.getState().setOk(0, 0, msg);
}
ctx.getMysqlChannel().reset();
- ctx.getState().setOk();
ctx.setRunProcedure(false);
ctx.setProcedureExec(null);
} catch (Exception e) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org