You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/05 16:53:30 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24230: Fix backwards-compatibility introduced by fixing mypy problems
potiuk opened a new pull request, #24230:
URL: https://github.com/apache/airflow/pull/24230
There was a backwards-incompatibility introduced by #23716 in
two providers by using get_mandatory_value config method.
This PR corrects that backwards compatibility and updates 2.1
compatibility pre-commit to check for forbidden usage of
get_mandatory_value.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24230:
URL: https://github.com/apache/airflow/pull/24230#issuecomment-1146847568
Found it when started to prepare provider's release :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24230:
URL: https://github.com/apache/airflow/pull/24230#discussion_r889715371
##########
scripts/ci/pre_commit/pre_commit_check_2_1_compatibility.py:
##########
@@ -91,6 +92,15 @@ def _check_file(_file: Path):
f"as it is not available in Airflow 2.2[/]"
)
+ if GET_MANDATORY_MATCHER.match(line):
+ errors.append(
+ f"[red]In {_file}:{index} there is a forbidden construct "
+ f"(Airflow 2.3+ only):[/]\n\n"
+ f"{lines[index]}\n\n"
+ f"[yellow]You should not use conf.get_mandatory_value "
+ f"as it is not available in Airflow 2.2[/]"
Review Comment:
Yes. But this change is only available in 2.3 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24230:
URL: https://github.com/apache/airflow/pull/24230#discussion_r889715530
##########
scripts/ci/pre_commit/pre_commit_check_2_1_compatibility.py:
##########
@@ -91,6 +92,15 @@ def _check_file(_file: Path):
f"as it is not available in Airflow 2.2[/]"
)
+ if GET_MANDATORY_MATCHER.match(line):
+ errors.append(
+ f"[red]In {_file}:{index} there is a forbidden construct "
+ f"(Airflow 2.3+ only):[/]\n\n"
+ f"{lines[index]}\n\n"
+ f"[yellow]You should not use conf.get_mandatory_value "
+ f"as it is not available in Airflow 2.2[/]"
Review Comment:
There will be a separate change about bumping min version to 2.2 after this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24230:
URL: https://github.com/apache/airflow/pull/24230#issuecomment-1146852433
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #24230:
URL: https://github.com/apache/airflow/pull/24230#discussion_r889715023
##########
scripts/ci/pre_commit/pre_commit_check_2_1_compatibility.py:
##########
@@ -91,6 +92,15 @@ def _check_file(_file: Path):
f"as it is not available in Airflow 2.2[/]"
)
+ if GET_MANDATORY_MATCHER.match(line):
+ errors.append(
+ f"[red]In {_file}:{index} there is a forbidden construct "
+ f"(Airflow 2.3+ only):[/]\n\n"
+ f"{lines[index]}\n\n"
+ f"[yellow]You should not use conf.get_mandatory_value "
+ f"as it is not available in Airflow 2.2[/]"
Review Comment:
Isn't the next provider release should set all providers to Airflow 2.2 as min version?
https://github.com/apache/airflow#support-for-providers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24230:
URL: https://github.com/apache/airflow/pull/24230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org