[GitHub] [flink] twalthr commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

[GitBox <gi...@apache.org>]

twalthr commented on code in PR #21203:
URL: https://github.com/apache/flink/pull/21203#discussion_r1043062247


##########
flink-table/flink-sql-parser-hive/pom.xml:
##########
@@ -63,11 +63,51 @@ under the License.
 				</exclusion>
 			</exclusions>
 		</dependency>
+		<dependency>
+			<groupId>org.apache.commons</groupId>
+			<artifactId>commons-lang3</artifactId>
+		</dependency>
 		<dependency>
 			<groupId>org.apache.calcite</groupId>
 			<artifactId>calcite-core</artifactId>
 			<version>${calcite.version}</version>
 			<exclusions>

Review Comment:
   Shouldn't `org.codehaus.janino:commons-compiler:jar:3.1.8` and `org.codehaus.janino:janino:jar:3.1.8` not be part of the `dependency:tree` output? 



##########
flink-table/flink-table-planner/pom.xml:
##########
@@ -49,6 +49,18 @@ under the License.
 				</exclusion>
 			</exclusions>
 		</dependency>
+		<dependency>

Review Comment:
   Thanks for the clarification. As long as the dependency does not end up in the jars we should be good then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org