You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Shwetha G S (JIRA)" <ji...@apache.org> on 2014/11/11 06:34:33 UTC
[jira] [Commented] (FALCON-869) Clean up required in the instance
API calls.
[ https://issues.apache.org/jira/browse/FALCON-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205969#comment-14205969 ]
Shwetha G S commented on FALCON-869:
------------------------------------
+ instance.startTime = jobInfo.getStartTime();
+ instance.endTime = jobInfo.getEndTime();
+ instance.logFile = jobInfo.getConsoleUrl();
This should also go inside STATUS?
> Clean up required in the instance API calls.
> --------------------------------------------
>
> Key: FALCON-869
> URL: https://issues.apache.org/jira/browse/FALCON-869
> Project: Falcon
> Issue Type: Improvement
> Reporter: Suhas Vasu
> Assignee: Suhas Vasu
> Priority: Minor
> Attachments: FALCON-869.patch
>
>
> The instance API calls all go through the same function and only later do specific stuff in the scheduler implementations. These specific stuff are too cluttered and a bunch of the stuff are done irrespective of the API call.
> Ex: GetWorkFlowParams are called even for a {{-kill}} even though it is not required.
> It would be good if we clean this up. It will help in code maintainability
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (FALCON-869) Clean up required in the instance
API calls.
Posted by Balu Vellanki <ba...@hortonworks.com>.
Please ignore the logs - I sent it by mistake.
sorry
Balu
On Mon, Nov 10, 2014 at 9:55 PM, Balu Vellanki <ba...@hortonworks.com> wrote:
> Yarn app logs
>
> On Mon, Nov 10, 2014 at 9:34 PM, Shwetha G S (JIRA) <ji...@apache.org>
> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/FALCON-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205969#comment-14205969
>> ]
>>
>> Shwetha G S commented on FALCON-869:
>> ------------------------------------
>>
>> + instance.startTime = jobInfo.getStartTime();
>> + instance.endTime = jobInfo.getEndTime();
>> + instance.logFile = jobInfo.getConsoleUrl();
>> This should also go inside STATUS?
>>
>> > Clean up required in the instance API calls.
>> > --------------------------------------------
>> >
>> > Key: FALCON-869
>> > URL: https://issues.apache.org/jira/browse/FALCON-869
>> > Project: Falcon
>> > Issue Type: Improvement
>> > Reporter: Suhas Vasu
>> > Assignee: Suhas Vasu
>> > Priority: Minor
>> > Attachments: FALCON-869.patch
>> >
>> >
>> > The instance API calls all go through the same function and only later
>> do specific stuff in the scheduler implementations. These specific stuff
>> are too cluttered and a bunch of the stuff are done irrespective of the API
>> call.
>> > Ex: GetWorkFlowParams are called even for a {{-kill}} even though it is
>> not required.
>> > It would be good if we clean this up. It will help in code
>> maintainability
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: [jira] [Commented] (FALCON-869) Clean up required in the instance
API calls.
Posted by Balu Vellanki <ba...@hortonworks.com>.
Yarn app logs
On Mon, Nov 10, 2014 at 9:34 PM, Shwetha G S (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/FALCON-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205969#comment-14205969
> ]
>
> Shwetha G S commented on FALCON-869:
> ------------------------------------
>
> + instance.startTime = jobInfo.getStartTime();
> + instance.endTime = jobInfo.getEndTime();
> + instance.logFile = jobInfo.getConsoleUrl();
> This should also go inside STATUS?
>
> > Clean up required in the instance API calls.
> > --------------------------------------------
> >
> > Key: FALCON-869
> > URL: https://issues.apache.org/jira/browse/FALCON-869
> > Project: Falcon
> > Issue Type: Improvement
> > Reporter: Suhas Vasu
> > Assignee: Suhas Vasu
> > Priority: Minor
> > Attachments: FALCON-869.patch
> >
> >
> > The instance API calls all go through the same function and only later
> do specific stuff in the scheduler implementations. These specific stuff
> are too cluttered and a bunch of the stuff are done irrespective of the API
> call.
> > Ex: GetWorkFlowParams are called even for a {{-kill}} even though it is
> not required.
> > It would be good if we clean this up. It will help in code
> maintainability
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.