[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2081: Added zookeeper host configuration. Closes #1960

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2081: Added zookeeper host configuration. Closes #1960
URL: https://github.com/apache/bookkeeper/pull/2081#discussion_r280741658
 
 

 ##########
 File path: stream/distributedlog/core/src/main/java/org/apache/distributedlog/LocalDLMEmulator.java
 ##########
 @@ -308,13 +308,15 @@ public static URI createDLMURI(String zkServers, String path) throws Exception {
     public static void main(String[] args) throws Exception {
         try {
             if (args.length < 1) {
-                System.out.println("Usage: LocalDLEmulator <zk_port>");
+                System.out.println("Usage: LocalDLEmulator <zk_host> <zk_port>");
                 System.exit(-1);
             }
 
-            final int zkPort = Integer.parseInt(args[0]);
+            final String zkHost = args[0];
+            final int zkPort = Integer.parseInt(args[1]);
 
 Review comment:
   Can we make it compatible with only version ?
   Just handle the case in which you have only one parameter

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services