You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/20 05:27:33 UTC
Review Request 70245: Moved CSI plugin metrics out from SLRP metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9632
https://issues.apache.org/jira/browse/MESOS-9632
Repository: mesos
Description
-------
This is a preliminary refactor patch for `ServiceManager` introduced in
the next patch. The CSI plugin metrics are moved out from SLRP metrics
object so the metrics can be accessed by `ServiceManager`. However, SLRP
still owns these metrics for now. Eventually we would like to decouple
metrics lifecycles from SLRP lifecycles.
Diffs
-----
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
src/csi/metrics.hpp PRE-CREATION
src/csi/metrics.cpp PRE-CREATION
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70245/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70245: Moved CSI plugin metrics out from SLRP
metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/#review213823
-----------------------------------------------------------
PASS: Mesos patch 70245 was successfully built and tested.
Reviews applied: `['70245']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2982/mesos-review-70245
- Mesos Reviewbot Windows
On March 20, 2019, 5:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70245/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 5:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9632
> https://issues.apache.org/jira/browse/MESOS-9632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a preliminary refactor patch for `ServiceManager` introduced in
> the next patch. The CSI plugin metrics are moved out from SLRP metrics
> object so the metrics can be accessed by `ServiceManager`. However, SLRP
> still owns these metrics for now. Eventually we would like to decouple
> metrics lifecycles from SLRP lifecycles.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70245/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70245: Moved CSI plugin metrics out from SLRP
metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/
-----------------------------------------------------------
(Updated March 27, 2019, 4:04 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased on top of r70316.
Bugs: MESOS-9632
https://issues.apache.org/jira/browse/MESOS-9632
Repository: mesos
Description
-------
This is a preliminary refactor patch for `ServiceManager` introduced in
the next patch. The CSI plugin metrics are moved out from SLRP metrics
object so the metrics can be accessed by `ServiceManager`. However, SLRP
still owns these metrics for now. Eventually we would like to decouple
metrics lifecycles from SLRP lifecycles.
Diffs (updated)
-----
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d
src/csi/metrics.hpp PRE-CREATION
src/csi/metrics.cpp PRE-CREATION
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70245/diff/3/
Changes: https://reviews.apache.org/r/70245/diff/2-3/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70245: Moved CSI plugin metrics out from SLRP
metrics.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 20, 2019, 6:50 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider_process.hpp
> > Line 402 (original), 403 (patched)
> > <https://reviews.apache.org/r/70245/diff/1/?file=2132897#file2132897line403>
> >
> > From r/70169: Benjamin: Composition instead of inheritance seems to work just fine here, let's do that instead.
> >
> > Chun-Hung: Yeah both work. The inheritance approach would enable us to use metrics.csi_plugin_container_termination instead of metrics.csiPluginMetrics.container_termination. WDYT?
Yes, that makes sense for a mere data class. Dropping.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/#review213820
-----------------------------------------------------------
On March 20, 2019, 6:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70245/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 6:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9632
> https://issues.apache.org/jira/browse/MESOS-9632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a preliminary refactor patch for `ServiceManager` introduced in
> the next patch. The CSI plugin metrics are moved out from SLRP metrics
> object so the metrics can be accessed by `ServiceManager`. However, SLRP
> still owns these metrics for now. Eventually we would like to decouple
> metrics lifecycles from SLRP lifecycles.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70245/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70245: Moved CSI plugin metrics out from SLRP
metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/#review213820
-----------------------------------------------------------
src/resource_provider/storage/provider_process.hpp
Line 402 (original), 403 (patched)
<https://reviews.apache.org/r/70245/#comment299887>
From r/70169: Benjamin: Composition instead of inheritance seems to work just fine here, let's do that instead.
Chun-Hung: Yeah both work. The inheritance approach would enable us to use metrics.csi_plugin_container_termination instead of metrics.csiPluginMetrics.container_termination. WDYT?
- Chun-Hung Hsiao
On March 20, 2019, 5:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70245/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 5:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9632
> https://issues.apache.org/jira/browse/MESOS-9632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a preliminary refactor patch for `ServiceManager` introduced in
> the next patch. The CSI plugin metrics are moved out from SLRP metrics
> object so the metrics can be accessed by `ServiceManager`. However, SLRP
> still owns these metrics for now. Eventually we would like to decouple
> metrics lifecycles from SLRP lifecycles.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70245/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70245: Moved CSI plugin metrics out from SLRP
metrics.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/#review213830
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 20, 2019, 6:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70245/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 6:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9632
> https://issues.apache.org/jira/browse/MESOS-9632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a preliminary refactor patch for `ServiceManager` introduced in
> the next patch. The CSI plugin metrics are moved out from SLRP metrics
> object so the metrics can be accessed by `ServiceManager`. However, SLRP
> still owns these metrics for now. Eventually we would like to decouple
> metrics lifecycles from SLRP lifecycles.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70245/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>