[PATCH] mod_speling [300] Multiple Choices bug (Take 2)

[Martin Kraemer <Ma...@mch.sni.de>]

On Fri, Jan 09, 1998 at 12:05:20PM +0100, Martin Kraemer wrote:
> Soeren, can you please test if the appended patch fixes it for you?

That was not the answer, of course. The "[300] Multiple Choices" links
of mod_speling were totally broken:

* they neither contained the absolute URI
  (this would have broken requests of
  "/.../valid_dir/invalid_dir/and/more/stuff/": if "invalid_dir" would
  result in ``Multiple Choices'' then they would be
  interpreted as "/.../valid_dir/invalid_dir/and/more/stuff/choice1" by the
  browser;       "/.../valid_dir/choice1/and/more/stuff/" would have been
  correct)

* they also forgot to append the trailing stuff: the first patch would
  return a link  "/.../valid_dir/choice1" instead of the more
  correct link   "/.../valid_dir/choice1/and/more/stuff/" for the example
  given above.

Try this patch.

   Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Re: [PATCH] mod_speling [300] Multiple Choices bug (Take 2)

[Dirk-Willem van Gulik <Di...@jrc.it>]

+1 tested. But if I have some time I'd like to chase memory; seems
a bit over the top.

Dw.

Re: [PATCH] mod_speling [300] Multiple Choices bug (Take 2)

[Dean Gaudet <dg...@arctic.org>]

+1 untested. 

Note your XXX regarding allocating lots of memory can be alleviated by
creating a sub_pool to do the work, and then just passing the t from the
sub_pool into table_set since it will be pstrdup()d into the main pool
when done.  It's still kind of yucky, but the memory is reclaimed this
way. 

Dean