You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2017/10/03 16:50:47 UTC

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1 

Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8198


Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................

IMPALA-6009: Upgrade Guava to 14.0.1

Builds are breaking because the latest hive-exec
snapshot jar includes Guava classes which conflict
with the version Impala depends on (11.0.2).

As a temporary workaround this patch upgrades
Impala's Guava dependency to verison 14.0.1 to be
consistent with the classes in hive-exec.

Testing:
- mvn compile succeeded

Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
---
M fe/pom.xml
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
2 files changed, 10 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8198/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 21:01:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8198

to look at the new patch set (#2).

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................

IMPALA-6009: Upgrade Guava to 14.0.1

Builds are breaking because the latest hive-exec
snapshot jar includes Guava 14.0.1 classes which
conflict with the version Impala depends on (11.0.2).

Between verisons 11.0.2 and 14.0.1 Guava changed the
API of some Hasher methods that Impala uses.

As a temporary workaround this patch upgrades
Impala's Guava dependency to version 14.0.1 to be
consistent with the classes in hive-exec.

Testing:
- mvn compile succeeded

Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
---
M fe/pom.xml
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
2 files changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8198/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 3:

I haven't tried it to make sure it works but I was reading about dependency exclusions in maven and I was wondering if that is a better solution. If I understand it correctly, you can declare that project guava under project hive is not a dependency and hence, it will not be included in our classpath.


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 17:56:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 1:

This patch works for me locally in that "./buildall.sh -noclean -notests -start_minicluster -start_impala_cluster" now succeeds.


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 16:57:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8198

to look at the new patch set (#3).

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................

IMPALA-6009: Upgrade Guava to 14.0.1

Builds are breaking because the latest hive-exec
snapshot jar includes Guava 14.0.1 classes which
conflict with the version Impala depends on (11.0.2).

Between versions 11.0.2 and 14.0.1 Guava changed the
API of some Hasher methods that Impala uses.

As a temporary workaround this patch upgrades
Impala's Guava dependency to version 14.0.1 to be
consistent with the classes in hive-exec.

Testing:
- mvn compile succeeded

Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
---
M fe/pom.xml
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
2 files changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8198/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 4: Verified+1 Code-Review+2

Going to merge this to unblock builds.


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 21:03:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8198/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8198/3//COMMIT_MSG@16
PS3, Line 16: temporary workaround
> Removed temporary.
Don't want to use a different version than Hive to avoid other version incompatibility issues.



-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 18:13:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................

IMPALA-6009: Upgrade Guava to 14.0.1

Builds are breaking because the latest hive-exec
snapshot jar includes Guava 14.0.1 classes which
conflict with the version Impala depends on (11.0.2).

Between versions 11.0.2 and 14.0.1 Guava changed the
API of some Hasher methods that Impala uses.

As a workaround this patch upgrades Impala's Guava
dependency to version 14.0.1 to be consistent with
the classes in hive-exec.

Testing:
- mvn compile succeeded

Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Reviewed-on: http://gerrit.cloudera.org:8080/8198
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Alex Behm <al...@cloudera.com>
---
M fe/pom.xml
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
2 files changed, 10 insertions(+), 11 deletions(-)

Approvals:
  Bharath Vissapragada: Looks good to me, but someone else must approve
  Dimitris Tsirogiannis: Looks good to me, approved
  Alex Behm: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 4: Code-Review+1

This change looks ok to me. But given its implications across multiple dependent projects, I'm not confident enough to +2 it. May be someone else can do that.


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 20:00:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1289/


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 03 Oct 2017 16:54:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8198/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8198/3//COMMIT_MSG@16
PS3, Line 16: temporary workaround
Why as a temporary workaround? IMO Guava upgrade is a good thing unless we are relying on something in 11.0.2 or if there is a better longterm solution. Also, I see that 14.0.1 is a pretty old version too [1]

[1] https://github.com/google/guava/wiki/Release14



-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 17:29:35 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has removed a vote on this change.

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Removed Code-Review-2 by Alex Behm <al...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 1: Code-Review-2

Setting to -2 to not auto-merge when GVO succeeds.


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 03 Oct 2017 16:55:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Michael Brown, Dimitris Tsirogiannis, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8198

to look at the new patch set (#4).

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................

IMPALA-6009: Upgrade Guava to 14.0.1

Builds are breaking because the latest hive-exec
snapshot jar includes Guava 14.0.1 classes which
conflict with the version Impala depends on (11.0.2).

Between versions 11.0.2 and 14.0.1 Guava changed the
API of some Hasher methods that Impala uses.

As a workaround this patch upgrades Impala's Guava
dependency to version 14.0.1 to be consistent with
the classes in hive-exec.

Testing:
- mvn compile succeeded

Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
---
M fe/pom.xml
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
2 files changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8198/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8198/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8198/3//COMMIT_MSG@16
PS3, Line 16: workaround this patc
> Why as a temporary workaround? IMO Guava upgrade is a good thing unless we 
Removed temporary.



-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 18:13:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 20:52:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 )

Change subject: IMPALA-6009: Upgrade Guava to 14.0.1
......................................................................


Patch Set 3:

Dimitris the Guava classes are included in the hive-exec jar - not as a transitive dependency.


-- 
To view, visit http://gerrit.cloudera.org:8080/8198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc5da8849d5aa7317d3dc572884d05dee859bdd
Gerrit-Change-Number: 8198
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 18:10:44 +0000
Gerrit-HasComments: No