[GitHub] [skywalking] yanickxia commented on issue #3619: Fix more resonable error

[GitBox <gi...@apache.org>]

yanickxia commented on issue #3619: Fix more resonable error
URL: https://github.com/apache/skywalking/pull/3619#issuecomment-542049502
 
 
   @wu-sheng  if `getRemoteClient` before `getFreeClients().clear();` then 
   ```java
          List<RemoteClient> clientList = clientManager.getRemoteClient();
           if (clientList.size() == 0) {  
               logger.warn("There is no available remote server for now, ignore the streaming data until the cluster metadata initialized.");
               return;
           }
   ```
   math the if condition, without any other code execute under it. 
   
   i think just guarantee the clientList be not modified after got it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services