You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Rashmi Hunt (JIRA)" <de...@tuscany.apache.org> on 2009/02/12 02:43:59 UTC

[jira] Created: (TUSCANY-2842) Problem in validation logic in Jira TUSCANY-2776

Problem in validation logic in Jira  TUSCANY-2776 
--------------------------------------------------

                 Key: TUSCANY-2842
                 URL: https://issues.apache.org/jira/browse/TUSCANY-2842
             Project: Tuscany
          Issue Type: Bug
            Reporter: Rashmi Hunt


This Jira fix has a bug in the validation logic which makes none of the service bindings with activationspec start even if they are valid.  Logic checks if connection factory 
and activationspec are mutually exclusive and if both exists it throws exception. In SCDL there is a ActivationSpec for the service and 
in JMSBinding class there is always default connectionFactory name defined.

public class JMSBinding ... {

	private String connectionFactoryName = JMSBindingConstants.DEFAULT_CONNECTION_FACTORY_NAME;)

}

 <binding.jms>
      <destination name="jms/HelloWorldJAXBService"/>
      <activationSpec name="jms/SCA_JMS_AS"/>

 </binding.jms>

Combination of these two, always results in error condition which shouldn't since there is no connectionfactory defined in SCDL

        // Connection factory and activation Specification are mutually exclusive.
        if (( connectionFactoryName != null ) && ( connectionFactoryName.length() > 0 )) {
            String activationSpecName = jmsBinding.getActivationSpecName();
            if ((activationSpecName != null) && (activationSpecName.length() > 0 )) {
                error("ConnectionFactoryActivationSpecContradiction", jmsBinding, connectionFactoryName, activationSpecName );                
            }
        }




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TUSCANY-2842) Problem in validation logic in Jira TUSCANY-2776

Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws reassigned TUSCANY-2842:
-----------------------------------

    Assignee: Simon Laws

> Problem in validation logic in Jira  TUSCANY-2776 
> --------------------------------------------------
>
>                 Key: TUSCANY-2842
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2842
>             Project: Tuscany
>          Issue Type: Bug
>            Reporter: Rashmi Hunt
>            Assignee: Simon Laws
>
> This Jira fix has a bug in the validation logic which makes none of the service bindings with activationspec start even if they are valid.  Logic checks if connection factory 
> and activationspec are mutually exclusive and if both exists it throws exception. In SCDL there is a ActivationSpec for the service and 
> in JMSBinding class there is always default connectionFactory name defined.
> public class JMSBinding ... {
> 	private String connectionFactoryName = JMSBindingConstants.DEFAULT_CONNECTION_FACTORY_NAME;)
> }
>  <binding.jms>
>       <destination name="jms/HelloWorldJAXBService"/>
>       <activationSpec name="jms/SCA_JMS_AS"/>
>  </binding.jms>
> Combination of these two, always results in error condition which shouldn't since there is no connectionfactory defined in SCDL
>         // Connection factory and activation Specification are mutually exclusive.
>         if (( connectionFactoryName != null ) && ( connectionFactoryName.length() > 0 )) {
>             String activationSpecName = jmsBinding.getActivationSpecName();
>             if ((activationSpecName != null) && (activationSpecName.length() > 0 )) {
>                 error("ConnectionFactoryActivationSpecContradiction", jmsBinding, connectionFactoryName, activationSpecName );                
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TUSCANY-2842) Problem in validation logic in Jira TUSCANY-2776

Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws resolved TUSCANY-2842.
---------------------------------

       Resolution: Fixed
    Fix Version/s: Java-SCA-Next

Actually resolved by Ant under TUSCANY-2820 r741542 in the 1.x branch. An extra check has been added to look for the connection factory being set to it's default name. 

> Problem in validation logic in Jira  TUSCANY-2776 
> --------------------------------------------------
>
>                 Key: TUSCANY-2842
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2842
>             Project: Tuscany
>          Issue Type: Bug
>            Reporter: Rashmi Hunt
>            Assignee: Simon Laws
>             Fix For: Java-SCA-Next
>
>
> This Jira fix has a bug in the validation logic which makes none of the service bindings with activationspec start even if they are valid.  Logic checks if connection factory 
> and activationspec are mutually exclusive and if both exists it throws exception. In SCDL there is a ActivationSpec for the service and 
> in JMSBinding class there is always default connectionFactory name defined.
> public class JMSBinding ... {
> 	private String connectionFactoryName = JMSBindingConstants.DEFAULT_CONNECTION_FACTORY_NAME;)
> }
>  <binding.jms>
>       <destination name="jms/HelloWorldJAXBService"/>
>       <activationSpec name="jms/SCA_JMS_AS"/>
>  </binding.jms>
> Combination of these two, always results in error condition which shouldn't since there is no connectionfactory defined in SCDL
>         // Connection factory and activation Specification are mutually exclusive.
>         if (( connectionFactoryName != null ) && ( connectionFactoryName.length() > 0 )) {
>             String activationSpecName = jmsBinding.getActivationSpecName();
>             if ((activationSpecName != null) && (activationSpecName.length() > 0 )) {
>                 error("ConnectionFactoryActivationSpecContradiction", jmsBinding, connectionFactoryName, activationSpecName );                
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.