You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org> on 2011/07/29 05:56:09 UTC
[jira] [Created] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
[MR-279] NM UI should get a read-only view instead of the actual NMContext
---------------------------------------------------------------------------
Key: MAPREDUCE-2745
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Reporter: Vinod Kumar Vavilapalli
Fix For: 0.23.0
NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth reassigned MAPREDUCE-2745:
--------------------------------------
Assignee: Anupam Seth
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-2745:
-----------------------------------------------
Status: Open (was: Patch Available)
Gah, cloning the maps upfront will prevent the web UI from reflecting any more changes to the map.
Let me step back and think what all we want to do here.
While I do that, let's punt this for now, there are more pressing issues that need attention.
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch, MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094644#comment-13094644 ]
Anupam Seth commented on MAPREDUCE-2745:
----------------------------------------
Test patch produces the following, but the 21 findBugs warnings have nothing to do with this patch:
*************************************************************************************************
-1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 22 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
*************************************************************************************************
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098219#comment-13098219 ]
Hadoop QA commented on MAPREDUCE-2745:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12493169/MAPREDUCE-2745-branch-0_23_v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/616//console
This message is automatically generated.
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch, MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096004#comment-13096004 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-2745:
----------------------------------------------------
Looked at the patch.
While I understand the intention, I think Immutable-records are going to be a maintenance nightmare.
We can instead simply return clones to the webUI - a copy of the maps should be enough. If you are willing to go the full distance, you could supply the clones for all those objects which you wrote Immutable versions for - ApplicationId, Container, Application, LocalResource etc. You can see {{BuilderUtils.clone(Container c)}} for example.
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated MAPREDUCE-2745:
-----------------------------------
Attachment: MAPREDUCE-2745-branch-0_23_v2.patch
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch, MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094661#comment-13094661 ]
Hadoop QA commented on MAPREDUCE-2745:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492470/MAPREDUCE-2745-branch-0_23.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/570//console
This message is automatically generated.
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated MAPREDUCE-2745:
-----------------------------------
Attachment: MAPREDUCE-2745-branch-0_23.patch
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-2745:
-----------------------------------------------
Priority: Trivial (was: Major)
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch, MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098114#comment-13098114 ]
Anupam Seth commented on MAPREDUCE-2745:
----------------------------------------
Thanks Vinod for the help and the feedback! I have uploaded new patch - kindly review and let me know if it doesn't look good.
Test patch returns the following, but again all the findbugs warnings are in packages other than what I have touched and unrelated to any of my changes.
-1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch, MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated MAPREDUCE-2745:
-----------------------------------
Affects Version/s: 0.23.0
Status: Patch Available (was: Open)
Sorry, meant all 22 in the comment above.
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2745) [MR-279] NM UI should get a
read-only view instead of the actual NMContext
Posted by "Arun C Murthy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-2745:
-------------------------------------
Fix Version/s: (was: 0.23.1)
0.24.0
> [MR-279] NM UI should get a read-only view instead of the actual NMContext
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2745
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Anupam Seth
> Priority: Trivial
> Labels: newbie
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-2745-branch-0_23.patch, MAPREDUCE-2745-branch-0_23_v2.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like the AM web-ui.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira