You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Andras Gyori (Jira)" <ji...@apache.org> on 2021/04/06 09:09:00 UTC
[jira] [Commented] (YARN-10723) Change CS nodes page in UI to
support custom resource.
[ https://issues.apache.org/jira/browse/YARN-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315369#comment-17315369 ]
Andras Gyori commented on YARN-10723:
-------------------------------------
Thank you [~zhuqi] for working on this issue. The patch looks good to me, can you provide a screenshot of custom resource on UI1? I have some minor comments:
* 248,250 String.valueOf is unnecessary
* nodesPage#L116 has a null check, but it is unnecessary. If this Map could contain a null key, its already troublesome, if it is not possible, then it is unnecessary. In either case, you have a integerEntry.getKey().equals before the null check, which would throw a NPE if you have a null key
> Change CS nodes page in UI to support custom resource.
> ------------------------------------------------------
>
> Key: YARN-10723
> URL: https://issues.apache.org/jira/browse/YARN-10723
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-10723.001.patch, YARN-10723.002.patch, YARN-10723.003.patch
>
>
> Node page now only support gpu for custom resource.
> We should make this supported for all custom resources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org