You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/14 15:26:47 UTC

[GitHub] [arrow] wesm commented on pull request #7748: ARROW-9388: [C++] Division kernels

wesm commented on pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#issuecomment-658245887


   This can't be merged yet. Divide by zero in the unchecked case causes SIGFPE process crash. 
   
   We should probably return null when dividing by zero, this is what Impala does
   
   https://github.com/apache/impala/blob/b5805de3e65fd1c7154e4169b323bb38ddc54f4f/be/src/exprs/operators-ir.cc#L60
   
   I'm curious what other database-type systems do


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org