You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Yun Gao (Jira)" <ji...@apache.org> on 2022/04/13 06:28:04 UTC

[jira] [Updated] (FLINK-19425) Correct the usage of BulkWriter#flush and BulkWriter#finish

     [ https://issues.apache.org/jira/browse/FLINK-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yun Gao updated FLINK-19425:
----------------------------
    Fix Version/s: 1.16.0

> Correct the usage of BulkWriter#flush and BulkWriter#finish
> -----------------------------------------------------------
>
>                 Key: FLINK-19425
>                 URL: https://issues.apache.org/jira/browse/FLINK-19425
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Common
>    Affects Versions: 1.11.0
>            Reporter: hailong wang
>            Priority: Minor
>              Labels: auto-deprioritized-major
>             Fix For: 1.11.0, 1.15.0, 1.16.0
>
>
> From the comments, BulkWriter#finish method should flush all buffer before close.
> But some subclasses of it do not flush data. These classes are as follows:
> 1.AvroBulkWriter#finish
> 2.HadoopCompressionBulkWriter#finish
> 3.NoCompressionBulkWriter#finish
> 4.SequenceFileWriter#finish
> We should invoke BulkWriter#flush in this finish methods.
> On the other hand, We don't have to  invoke BulkWriter#flush in close method. For BulkWriter#finish will flush all data.
> 1. HadoopPathBasedPartFileWriter#closeForCommit
> 2. BulkPartWriter#closeForCommit
> 3. FileSystemTableSink#OutputFormat#close
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)