You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/24 21:58:36 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6423: [AIRFLOW-5748] Remove python auto-detection

ashb commented on a change in pull request #6423: [AIRFLOW-5748] Remove python auto-detection
URL: https://github.com/apache/airflow/pull/6423#discussion_r338810275
 
 

 ##########
 File path: common/_autodetect_variables.sh
 ##########
 @@ -144,8 +119,8 @@ if [[ ! ${AUTODETECT_LONG_PYTHON_VERSION} =~ python[3]\.[0-9]+ ]]; then
     exit 1
 fi
 
-# Now set the auto-detected python version based on the auto-detected long version
-export PYTHON_VERSION=${AUTODETECT_LONG_PYTHON_VERSION#python}
+# Unless python_version is
 
 Review comment:
   ```suggestion
   # Unless python_version is set
   ```
   Half-written comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services