[GitHub] [superset] rusackas commented on a change in pull request #15709: fix(dashboard): Remove edit from url params when discarding changes

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #15709:
URL: https://github.com/apache/superset/pull/15709#discussion_r671974087



##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -129,7 +129,10 @@ const StyledDashboardHeader = styled.div`
 
 class Header extends React.PureComponent {
   static discardChanges() {
-    window.location.reload();
+    const url = new URL(window.location.href);
+
+    url.searchParams.delete('edit');
+    window.location.replace(url);

Review comment:
       I'm also curious if there might be any expectation for the back button to work. If so, it might be worth trying `window.location.assign(url)` or `window.location = url` or `window.location.href = url` (which all do the same thing)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org