You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wsrp4j-dev@portals.apache.org by "Ricky Frost (JIRA)" <ws...@ws.apache.org> on 2004/11/12 18:58:32 UTC
[jira] Created: (WSRP4J-41) The consumer.driver.ProducerImpl always asks for all locales on a getServiceDescription
The consumer.driver.ProducerImpl always asks for all locales on a getServiceDescription
---------------------------------------------------------------------------------------
Key: WSRP4J-41
URL: http://nagoya.apache.org/jira/browse/WSRP4J-41
Project: WSRP4J
Type: Improvement
Components: Consumer
Versions: current (nightly)
Environment: Tomcat 4.1.30, Win XP, etc
Reporter: Ricky Frost
There isn't a easy way to set the desiredLocales element while formulating the request...
I propose the following:
In getServiceDescription(boolean newRequest) there is the following...
// TODO: Set desired locales which are supported by the consumer
//request.setDesiredLocales(new String[]{Constants.LOCALE_EN_US, Constants.LOCALE_DE_DE});
// for now request all locales
request.setDesiredLocales(null);
Replace it with:
request.setDesiredLocales( desiredLocales );
And add the following member and method:
private String desiredLocales[] = { Locale.ENGLISH.toString() };
public void setDesiredLocales( String desiredLocales[] )
{
this.desiredLocales = desiredLocales;
}
That way when the proxyportlet instantiates the ProducerImpl it can set it according to the consumer environment locales...
This is the change I made in my local system...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (WSRP4J-41) The consumer.driver.ProducerImpl always asks for all locales on a getServiceDescription
Posted by "Mikhail Melamud (JIRA)" <ws...@ws.apache.org>.
[ http://nagoya.apache.org/jira/browse/WSRP4J-41?page=comments#action_55480 ]
Mikhail Melamud commented on WSRP4J-41:
---------------------------------------
Producer interface should be changed to accommodate getter/setter for desiredLocales, so that any Producer implementation would be required to implement it... WSRP 1.0 spec mentions importance of passing specific set of locales to decrease network transmission impact and, even more important, serialization/deserialization processing time.
Adding getter/setter for desired locales to the Producer interface is more generic and cleaner approach than simply change ProducerImpl
> The consumer.driver.ProducerImpl always asks for all locales on a getServiceDescription
> ---------------------------------------------------------------------------------------
>
> Key: WSRP4J-41
> URL: http://nagoya.apache.org/jira/browse/WSRP4J-41
> Project: WSRP4J
> Type: Improvement
> Components: Consumer
> Versions: current (nightly)
> Environment: Tomcat 4.1.30, Win XP, etc
> Reporter: Ricky Frost
>
> There isn't a easy way to set the desiredLocales element while formulating the request...
> I propose the following:
> In getServiceDescription(boolean newRequest) there is the following...
> // TODO: Set desired locales which are supported by the consumer
> //request.setDesiredLocales(new String[]{Constants.LOCALE_EN_US, Constants.LOCALE_DE_DE});
> // for now request all locales
> request.setDesiredLocales(null);
> Replace it with:
> request.setDesiredLocales( desiredLocales );
> And add the following member and method:
> private String desiredLocales[] = { Locale.ENGLISH.toString() };
> public void setDesiredLocales( String desiredLocales[] )
> {
> this.desiredLocales = desiredLocales;
> }
> That way when the proxyportlet instantiates the ProducerImpl it can set it according to the consumer environment locales...
> This is the change I made in my local system...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira