You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/06/14 17:09:53 UTC

svn commit: r1493107 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java

Author: sebb
Date: Fri Jun 14 15:09:53 2013
New Revision: 1493107

URL: http://svn.apache.org/r1493107
Log:
Add more tests showing the behaviour on the index boundary

Modified:
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java

Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java?rev=1493107&r1=1493106&r2=1493107&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java Fri Jun 14 15:09:53 2013
@@ -619,6 +619,12 @@ public class StringUtilsEqualsIndexOfTes
         assertEquals(2, StringUtils.indexOf("aabaabaa", "b", -1));
         assertEquals(2,StringUtils.indexOf("aabaabaa", "", 2));
 
+        // Test that startIndex works correctly, i.e. cannot match before startIndex
+        assertEquals(7, StringUtils.indexOf("12345678", "8", 5));
+        assertEquals(7, StringUtils.indexOf("12345678", "8", 6));
+        assertEquals(7, StringUtils.indexOf("12345678", "8", 7)); // 7 is last index
+        assertEquals(-1, StringUtils.indexOf("12345678", "8", 8));
+
         assertEquals(5, StringUtils.indexOf(new StringBuilder("aabaabaa"), "b", 3));
     }
 
@@ -843,6 +849,13 @@ public class StringUtilsEqualsIndexOfTes
         assertEquals(-1, StringUtils.lastIndexOf("aabaabaa", "b", -1));
         assertEquals(-1, StringUtils.lastIndexOf("aabaabaa", "b", 0));
         assertEquals(0, StringUtils.lastIndexOf("aabaabaa", "a", 0));
+        assertEquals(-1, StringUtils.lastIndexOf("aabaabaa", "a", -1));
+
+        // Test that fromIndex works correctly, i.e. cannot match after fromIndex
+        assertEquals(7, StringUtils.lastIndexOf("12345678", "8", 9));
+        assertEquals(7, StringUtils.lastIndexOf("12345678", "8", 8));
+        assertEquals(7, StringUtils.lastIndexOf("12345678", "8", 7)); // 7 is last index
+        assertEquals(-1, StringUtils.lastIndexOf("12345678", "8", 6));
 
         assertEquals(2, StringUtils.lastIndexOf(new StringBuilder("aabaabaa"), "b", 3));
     }