You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/26 10:51:06 UTC
[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #6933: sim: Added gcov dump on application exit.
fjpanag opened a new pull request, #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933
## Summary
Added gcov data dumping when the simulator exits.
## Impact
Gcov can be used without NSH and the gcov app.
## Testing
Tested that the simulator indeed creates the `.gcda` files on exit.
The `tools/gcov.sh` script creates a correct report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#issuecomment-1228395751
I am not sure what is the style problem:
```
up_hostmisc.c:62:9: error: Mixed case identifier found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#discussion_r956005949
##########
arch/sim/src/sim/win/up_hostmisc.c:
##########
@@ -40,6 +48,12 @@
void host_abort(int status)
{
+#ifdef CONFIG_ARCH_COVERAGE
+ /* Dump gcov data. */
+
+ __gcov_dump();
Review Comment:
could be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#discussion_r956006259
##########
arch/sim/src/sim/win/up_hostmisc.c:
##########
@@ -40,6 +48,12 @@
void host_abort(int status)
{
+#ifdef CONFIG_ARCH_COVERAGE
+ /* Dump gcov data. */
+
+ __gcov_dump();
Review Comment:
Oh, you mean specifically for Windows? And keeping only the Posix one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#discussion_r956002068
##########
arch/sim/src/sim/win/up_hostmisc.c:
##########
@@ -40,6 +48,12 @@
void host_abort(int status)
{
+#ifdef CONFIG_ARCH_COVERAGE
+ /* Dump gcov data. */
+
+ __gcov_dump();
Review Comment:
In this case `CONFIG_ARCH_COVERAGE` shouldn't be enabled, right?
Maybe we should fix the dependencies of `CONFIG_ARCH_COVERAGE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#discussion_r956036654
##########
arch/sim/src/sim/win/up_hostmisc.c:
##########
@@ -40,6 +48,12 @@
void host_abort(int status)
{
+#ifdef CONFIG_ARCH_COVERAGE
+ /* Dump gcov data. */
+
+ __gcov_dump();
Review Comment:
OK done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#discussion_r956000600
##########
arch/sim/src/sim/win/up_hostmisc.c:
##########
@@ -40,6 +48,12 @@
void host_abort(int status)
{
+#ifdef CONFIG_ARCH_COVERAGE
+ /* Dump gcov data. */
+
+ __gcov_dump();
Review Comment:
let's revert the change. __gcov_dump is specific to gcc/clang, so it can't work with msvc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6933: sim: Added gcov dump on application exit.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6933:
URL: https://github.com/apache/incubator-nuttx/pull/6933#discussion_r956015327
##########
arch/sim/src/sim/win/up_hostmisc.c:
##########
@@ -40,6 +48,12 @@
void host_abort(int status)
{
+#ifdef CONFIG_ARCH_COVERAGE
+ /* Dump gcov data. */
+
+ __gcov_dump();
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org