You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/08/25 00:40:23 UTC
[jira] Created: (HADOOP-6926) SocketInputStream incorrectly
implements read()
SocketInputStream incorrectly implements read()
-----------------------------------------------
Key: HADOOP-6926
URL: https://issues.apache.org/jira/browse/HADOOP-6926
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 0.21.0, 0.20.2
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
Fix For: 0.22.0
SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928495#action_12928495 ]
Hadoop QA commented on HADOOP-6926:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12452982/hadoop-6926.txt
against trunk revision 1031422.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1049 javac compiler warnings (more than the trunk's current 1048 warnings).
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/20//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/20//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/20//console
This message is automatically generated.
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6926:
------------------------------
Fix Version/s: 0.22.0
Status: Patch Available (was: Open)
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.2, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6926:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Todd!
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903667#action_12903667 ]
Todd Lipcon commented on HADOOP-6926:
-------------------------------------
Ran unit tests locally. All passed except for TestListFiles (fixed by HADOOP-6933).
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6926:
------------------------------
Attachment: HADOOP-6926.patch
+1
The javac compilation error was due to:
{noformat}
< [javac] /Users/tom/workspace/hadoop-common-trunk/src/test/core/org/apache/hadoop/net/TestSocketIOWithTimeout.java:112: warning: [cast] redundant cast to int
< [javac] assertEquals((int)(byteWithHighBit & 0xff), in.read());
{noformat}
Here's a new patch with the cast removed.
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928925#action_12928925 ]
Hudson commented on HADOOP-6926:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #417 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/417/])
HADOOP-6926. SocketInputStream incorrectly implements read(). Contributed by Todd Lipcon.
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928954#action_12928954 ]
Hudson commented on HADOOP-6926:
--------------------------------
Integrated in Hadoop-Common-trunk #504 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/504/])
HADOOP-6926. SocketInputStream incorrectly implements read(). Contributed by Todd Lipcon.
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6926:
--------------------------------
Status: Patch Available (was: Open)
Affects Version/s: 0.22.0
Fix Version/s: (was: 0.22.0)
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.2, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6926:
------------------------------
Status: Open (was: Patch Available)
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.2, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928886#action_12928886 ]
Hadoop QA commented on HADOOP-6926:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12458969/HADOOP-6926.patch
against trunk revision 1031743.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/78//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/78//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/78//console
This message is automatically generated.
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly
implements read()
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6926:
--------------------------------
Attachment: hadoop-6926.txt
> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
> Key: HADOOP-6926
> URL: https://issues.apache.org/jira/browse/HADOOP-6926
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.