You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/01/13 12:28:10 UTC

[GitHub] wu-sheng opened a new pull request #2156: Support Service Instance Inventory properties and bug fixed

wu-sheng opened a new pull request #2156: Support Service Instance Inventory properties and bug fixed
URL: https://github.com/apache/incubator-skywalking/pull/2156
 
 
   1. Add instance inventory properties, which are very similar to service inventory.
   1. Move OSInfo properties into instance inventory properties. And remove those columns.
   1. Fix a service nodeType update bug. Service inventory properties update made nodeType failure. These two updates happen at nearly the same time, but because of dirty existing data, nodeType and properties wouldn't be successful at the same time. cc @liuhaoyang 
   
   FYI @peng-yongsheng 
   
   @ascrutae @liuhaoyang Could you test for node.js and .net after this merge? I think this could be the last feature related update in GA release.
   
   cc @apache/skywalking-committers 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services