You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "troizet (via GitHub)" <gi...@apache.org> on 2023/02/06 15:50:03 UTC

[GitHub] [netbeans] troizet opened a new pull request, #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

troizet opened a new pull request, #5443:
URL: https://github.com/apache/netbeans/pull/5443

   What was done in this PR:
   - fixed issue #5427
   - new tests for fixed issue have been added
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#issuecomment-1425254917

   A question added, let's wait for a while :) Then, let's make it. Thanks for this fix!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#issuecomment-1425152474

   @tmysik If there is no problem, let's merge it :) Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] troizet commented on pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#issuecomment-1425319460

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik merged pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik merged PR #5443:
URL: https://github.com/apache/netbeans/pull/5443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on a diff in pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#discussion_r1102321653


##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -454,6 +454,20 @@ private void extractPHPDocBlock() {
                     others.toString()));
         }
 
+        private boolean tagInTagsList(List<PHPDocTag> tags, AnnotationParsedLine tagKind) {

Review Comment:
   Likely not a problem here, but using a `Set` and simple lookup instead of `List` and iteration would be (much) better here. Would that be possible?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#issuecomment-1424708996

   @junichi11 could you also please have a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] troizet commented on a diff in pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on code in PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#discussion_r1102364197


##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -454,6 +454,20 @@ private void extractPHPDocBlock() {
                     others.toString()));
         }
 
+        private boolean tagInTagsList(List<PHPDocTag> tags, AnnotationParsedLine tagKind) {

Review Comment:
   For the reason that I am a php developer, I know java only superficially :) Thanks for the tip. I will keep it in mind next time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on a diff in pull request #5443: [GH-5427] PHP: Fix for displaying property type in documentation if @…

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #5443:
URL: https://github.com/apache/netbeans/pull/5443#discussion_r1102380592


##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -454,6 +454,20 @@ private void extractPHPDocBlock() {
                     others.toString()));
         }
 
+        private boolean tagInTagsList(List<PHPDocTag> tags, AnnotationParsedLine tagKind) {

Review Comment:
   OK, so maybe @junichi11 could try to improve it one day :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists