[GitHub] [solr] janhoy commented on a diff in pull request #1920: SOLR-16975: Remove loading of solr.xml from zookeeper (main branch only)

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on code in PR #1920:
URL: https://github.com/apache/solr/pull/1920#discussion_r1324801075


##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -299,8 +299,9 @@ public MiniSolrCloudCluster(
             .withUrl(zkServer.getZkHost())
             .withTimeout(AbstractZkTestCase.TIMEOUT, TimeUnit.MILLISECONDS)
             .build()) {
-      if (!zkClient.exists("/solr/solr.xml", true)) {
-        zkClient.makePath("/solr/solr.xml", solrXml.getBytes(Charset.defaultCharset()), true);
+      // NOCOMMIT: Create chroot here, not sure why it is now necessary?
+      zkClient.makePath("/solr", false, true);

Review Comment:
   Earlier line 303 always created `/solr/solr.xml`, so when that is removed, and security is not enabled, we need to create `/solr` manually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org