[GitHub] [nifi] SandishKumarHN commented on a change in pull request #3295: NIFI-5956 Option BlockCache for HBase Scan Processor

[GitBox <gi...@apache.org>]

SandishKumarHN commented on a change in pull request #3295: NIFI-5956 Option BlockCache for HBase Scan Processor
URL: https://github.com/apache/nifi/pull/3295#discussion_r261366050
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
 ##########
 @@ -161,12 +161,13 @@
      * @param timerangeMax the maximum timestamp of cells to return, passed to the HBase scanner timeRange
      * @param limitRows the maximum number of rows to be returned by scanner
      * @param isReversed whether this scan is a reversed one.
+     * @param blockCache set to use the block cache option of hbase scan.
      * @param columns optional columns to return, if not specified all columns are returned
      * @param authorizations optional list of visibility labels that the user should be able to see when communicating with HBase
      * @param handler a handler to process rows of the result
      */
     void scan(String tableName, String startRow, String endRow, String filterExpression, Long timerangeMin, Long timerangeMax, Integer limitRows,
-            Boolean isReversed, Collection<Column> columns, List<String> authorizations, ResultHandler handler) throws IOException;
+            Boolean isReversed, Boolean blockCache, Collection<Column> columns, List<String> authorizations, ResultHandler handler) throws IOException;
 
 Review comment:
    any thoughts @arpadboda ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services