You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2021/05/21 23:45:07 UTC

[GitHub] [roller] nuzayats commented on pull request #75: Ipbanlist fixes

nuzayats commented on pull request #75:
URL: https://github.com/apache/roller/pull/75#issuecomment-846311708


   > i don't feel that it adds enough benefits in this particular case, to justify a new test dependency (just for one small junit test).
   
   For this one at least it adds some benefit I think for example:
   
   `assertThat(readIpBanList()).containsOnly("10.0.0.1");`
   
   The standard assertion APIs don't provide such a collection verification if I'm not mistaken. Also to me having a new test dependency is not such a big deal but is there something which concerns you about it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org