[GitHub] RongtongJin edited a comment on issue #466: [ISSUE #465] topic should be added to topicList instead of clu…

[GitBox <gi...@apache.org>]

RongtongJin edited a comment on issue #466: [ISSUE #465] topic should be added to topicList instead of clu…
URL: https://github.com/apache/rocketmq/pull/466#issuecomment-423037072
 
 
   I think my understanding of systemTopicList is incorrect.
   At the beginning, I thought that getSystemTopicList means getting all the topic names, then I read the code carefully yesterday and found [RouteInfoManager.getAllTopicList()](https://github.com/apache/rocketmq/blob/a220364b752669c474f9795884faed9bb4e0a8c1/namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java#L86) has done this. I traced the call chain of getSystemToplicList and found [MQClientAPIImpl.getSystemTopicList()](https://github.com/apache/rocketmq/blob/a220364b752669c474f9795884faed9bb4e0a8c1/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java#L1600) is the last method called, so RouteManagerInfo.getSystemTopicList() never be called? ? ? 
   At the same time, I found some systemTopic will be added in [rocketmq.broker.topic.TopicConfigManager#TopicConfigManager()](https://github.com/apache/rocketmq/blob/a220364b752669c474f9795884faed9bb4e0a8c1/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java#L57) when the BrokerController is initialized, including the broker name and cluster name. So systemTopicList should include broker name and cluster name. The original code is correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services