[jira] [Commented] (YARN-496) Fair scheduler configs are refreshed inconsistently in reinitialize

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609579#comment-13609579 ] 

Karthik Kambatla commented on YARN-496:
---------------------------------------

There seems to be unnecessary code duplication in reinitialize(). A cleaner approach might be to move things around a little to avoid duplication.

{code}
// do common initialization stuff for both first time initialization and subsequent reinitializations
if (first-time-initialization) {
  // do first-time stuff
}
{code}
                
> Fair scheduler configs are refreshed inconsistently in reinitialize
> -------------------------------------------------------------------
>
>                 Key: YARN-496
>                 URL: https://issues.apache.org/jira/browse/YARN-496
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>            Priority: Minor
>         Attachments: YARN-496.patch
>
>
> When FairScheduler#reinitialize is called, some of the scheduler-wide configs are refreshed and others aren't.  They should all be refreshed.
> Ones that are refreshed: userAsDefaultQueue, nodeLocalityThreshold, rackLocalityThreshold, preemptionEnabled
> Ones that aren't: minimumAllocation, maximumAllocation, assignMultiple, maxAssign

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira