[GitHub] [netbeans] junichi11 commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action

[GitBox <gi...@apache.org>]

junichi11 commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528269270



##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
                 if (fileObject == null) {
                     continue;
                 }
+                if (cancelled) {
+                    cancelled = false;

Review comment:
       Maybe, need not this. `cancelled` is used only here at the moment, but I think we should keep the cancelled state. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists