You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/10/31 08:08:07 UTC
[PR] [HUDI-7013] Drop table command cannot delete dir when purge is enable [hudi]
xuzifu666 opened a new pull request, #9960:
URL: https://github.com/apache/hudi/pull/9960
### Change Logs
In some case even when purge is set true, truncate or drop with prurge enable but dir cannot be deleted
### Impact
delete dir with recursive
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788803429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789169275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788963617",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1789121757",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788957257
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9960:
URL: https://github.com/apache/hudi/pull/9960#discussion_r1378314872
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
emm，in some extreme case sub-dir contains dir，cause not delete completely. then change it to true，all files can be delete rightly @danny0405
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
emm，in some extreme case sub-dir contains dir，cause not delete completely. then change it to true，all files can be delete rightly @danny0405
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
in some extreme case sub-dir contains dir，cause not delete completely. then change it to true，all files can be delete rightly @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789121757
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788313872
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789919965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788963617",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1789121757",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1789894304",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789043562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788963617",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789151907
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788963617",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1789121757",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1787298516
@danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789914381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788963617",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1789121757",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1789894304",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1786715463
` // Recursively delete table directories
if (purge) {
logInfo("Clean up " + basePath)
val targetPath = new Path(basePath)
val engineContext = new HoodieSparkEngineContext(sparkSession.sparkContext)
val fs = FSUtils.getFs(basePath, sparkSession.sparkContext.hadoopConfiguration)
FSUtils.deleteDir(engineContext, fs, targetPath, sparkSession.sparkContext.defaultParallelism)
}`
but :
`public static boolean deleteDir(
HoodieEngineContext hoodieEngineContext, FileSystem fs, Path dirPath, int parallelism) {
try {
if (fs.exists(dirPath)) {
FSUtils.parallelizeSubPathProcess(hoodieEngineContext, fs, dirPath, parallelism, e -> true,
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
);
boolean result = fs.delete(dirPath, false);
LOG.info("Removed directory at " + dirPath);
return result;
}
} catch (IOException ioe) {
throw new HoodieIOException(ioe.getMessage(), ioe);
}
return false;
}`
boolean result = fs.delete(dirPath, false); this cause dir cannot be delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788302016
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789894304
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9960:
URL: https://github.com/apache/hudi/pull/9960#discussion_r1378275438
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
I'm confused, this deletion happens recursely from sub-dir to parent dir, why we need the `true` flag then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9960:
URL: https://github.com/apache/hudi/pull/9960#discussion_r1378314872
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(), pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
in some extreme case sub-dir contains dir，cause not delete completely. then change it to true，all files can be delete rightly，so it set to true to comfirm all files can be delete and not bring any risk @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788890157
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1789924249
azure seems had some problem，would be cancel soon after run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788940686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788963617
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9960:
URL: https://github.com/apache/hudi/pull/9960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7013] Drop table command cannot delete dir even when purge is enable [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9960:
URL: https://github.com/apache/hudi/pull/9960#issuecomment-1788972108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"triggerType" : "PUSH"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593",
"triggerID" : "1788890157",
"triggerType" : "MANUAL"
}, {
"hash" : "0d690d42416e63d40ebd8cf88d5f640e488adf6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1788963617",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d690d42416e63d40ebd8cf88d5f640e488adf6e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org