You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by hsaputra <gi...@git.apache.org> on 2015/10/09 22:26:24 UTC
[GitHub] incubator-twill pull request: Remove the if-check in the YarnTwill...
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-twill/pull/67
Remove the if-check in the YarnTwillPreparer class for log level when setting env key.
Add precondition check in the setLogLevel method to prevent setting null early.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-twill remove_if_check_yartwillpreparer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit dda60b8cca95f618694ee2063706c104ab6182e7
Author: hsaputra <hs...@apache.org>
Date: 2015-10-09T20:23:28Z
Remove the if-check in the YarnTwillPreparer class for log level when setting env key.
Add precondition check in the setLogLevel method to prevent setting null early.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: [CLEANUP] Remove the if-check in the...
Posted by gsps1 <gi...@git.apache.org>.
Github user gsps1 commented on the pull request:
https://github.com/apache/incubator-twill/pull/67#issuecomment-146978990
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: [CLEANUP] Remove the if-check in the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-twill/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: [CLEANUP] Remove the if-check in the...
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the pull request:
https://github.com/apache/incubator-twill/pull/67#issuecomment-146980768
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: [CLEANUP] Remove the if-check in the...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-twill/pull/67#issuecomment-146982297
Thanks for the review, guys.
Will wait until check pass and will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---